forked from awakesecurity/proto3-wire
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge upstream #5
Open
4eUeP
wants to merge
10
commits into
hstreamdb:master
Choose a base branch
from
awakesecurity:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now stack support lags behind.
We want to inline the field number because it is often a constant. But by forcing the entire fold to be INLINE, not just the field number, we force an impossible choice on proto3-suite: inline nothing or everything. Therefore we leave the actual folds merely INLINABLE. (If that is insufficient control then we may have to expose a more complex API.) Also give the compiler more discretion about whether to inline varints.
* Bump upper bounds * cabal build all components by default
v1.4.3: support GHC 9.6, 9.8 Skip GHC 9.0+Darwin due to crypton problem.
When encoding from a Data.Vector.Vector this library would already encode from right to left in order to avoid saving all but the final element to the stack. The relevant encoders would also exploit the fact that vectors have known element counts in order to consolidate size checks and associated reallocations when encoding packed fields with fixed-width elements. This change adds new encoders that generalize those two optimizations to other types of container such as `Data.Sequence.Seq`. When a container does not support right-to-left iteration and/or length prediction (for example, a standard list), these new encoders still support them as efficiently as is practical, given those restrictions. Also added: * bytesIfNonempty * etaMessageBuilder * repeatedMessageBuilder * unsafeFromByteString * unsafeFromShortByteString
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.